Upgrade to oclif core v3 #102
Conversation
There was a problem hiding this comment.
Great stuff! I just tested this branch on my new heroku cli plugin, and it works great. The latest oclif generate scaffolds a structure for the oclif3-compatible plugins only, and the latest stable heroku-cli/command gave me a types mismatch error in TypeScript. Any chances this PR gets merged any time soon? :) I'd really like to release my plugin, though it would be tricky if one of it's dependencies is pulled from Gh repo and should be built right after installing.
|
Hi @ryandagg! Any chances for this to be merged soon? :) |
|
Hi @lancedikson I can see you are excited about this (we are too!).. However, there is some other significant work that must be done (primarily with our own plugins) before we can incorporate this into the CLI. The good news is that work has been prioritized and we will be tackling it soon. For now, I'm going to close this PR. |
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001cOMR2YAO/view
Had to update the branch protection rules for master to accommodate the new test names.
https://github.com/heroku/heroku-cli-command/settings/branch_protection_rules/1052008
From
test ($OS-matix, lts/gallium) && test ($OS-matix, lts/fermium)
to
test ($OS-matix, 18.x)